Skip to content
CI

feat: migrate to latest action controller for crystal 1.13 support #362

Sign in to view logs

feat: migrate to latest action controller for crystal 1.13 support

feat: migrate to latest action controller for crystal 1.13 support #362

Triggered via push July 16, 2024 07:49
@stakachstakach
pushed f132fcb
main
Status Success
Total duration 1m 59s
Artifacts –

ci.yml

on: push
test  /  TODOs → GitHub Issues
0s
test / TODOs → GitHub Issues
crystal-style  /  crystal-style
1m 51s
crystal-style / crystal-style
Matrix: test / test
Fit to window
Zoom out
Zoom in

Annotations

9 warnings and 11 notices
test / 🚧 crystal: unstable, MT: ☐, canary: ☐
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
test / crystal: latest, MT: ☐, canary: ☐
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Lint/MissingBlockArgument: src/placeos-build/api/repositories.cr#L77
Missing anonymous block argument. Use `&` as an argument name to indicate yielding method.
Lint/MissingBlockArgument: src/placeos-build/drivers.cr#L335
Missing anonymous block argument. Use `&` as an argument name to indicate yielding method.
Lint/Formatting: src/placeos-build/api/driver.cr#L1
Use built-in formatter to format this source
Lint/NotNil: src/placeos-build/digest/dependency_graph.cr#L124
Avoid using `not_nil!`
Lint/MissingBlockArgument: src/placeos-build/client.cr#L35
Missing anonymous block argument. Use `&` as an argument name to indicate yielding method.
Lint/MissingBlockArgument: src/placeos-build/client.cr#L45
Missing anonymous block argument. Use `&` as an argument name to indicate yielding method.
crystal-style / crystal-style
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Style/QueryBoolMethods: src/placeos-build/cli.cr#L33
Consider using 'getter?' for 'version'
Style/QueryBoolMethods: src/placeos-build/cli.cr#L37
Consider using 'getter?' for 'environment'
Style/PredicateName: src/placeos-build/driver_store/s3.cr#L173
Favour method name 'elf?' over 'is_elf?'
Style/QueryBoolMethods: src/placeos-build/digest/cli.cr#L106
Consider using 'getter?' for 'verbose'
Style/QueryBoolMethods: src/placeos-build/cli/server.cr#L18
Consider using 'getter?' for 'routes'
Style/ParenthesesAroundCondition: src/placeos-build/digest/dependency_graph.cr#L94
Redundant parentheses
Style/ParenthesesAroundCondition: src/placeos-build/cli/build.cr#L60
Redundant parentheses
Style/ParenthesesAroundCondition: src/placeos-build/cli/build.cr#L96
Redundant parentheses
Style/PredicateName: src/placeos-build/cli/build.cr#L107
Favour method name 'driver?' over 'is_driver?'
Style/QueryBoolMethods: src/placeos-build/cli/build.cr#L26
Consider using 'getter?' for 'strict_driver_info'
Style/QueryBoolMethods: src/placeos-build/cli/build.cr#L29
Consider using 'getter?' for 'discover'