Skip to content

Merge pull request #57 from PlaceOS/PPT-1335 #290

Merge pull request #57 from PlaceOS/PPT-1335

Merge pull request #57 from PlaceOS/PPT-1335 #290

Triggered via push April 17, 2024 13:04
Status Success
Total duration 8m 22s
Artifacts

build.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

6 warnings and 12 notices
Lint/NotNil: src/placeos-build/digest/dependency_graph.cr#L124
Avoid using `not_nil!`
Lint/MissingBlockArgument: src/placeos-build/api/repositories.cr#L89
Missing anonymous block argument. Use `&` as an argument name to indicate yielding method.
Lint/MissingBlockArgument: src/placeos-build/drivers.cr#L335
Missing anonymous block argument. Use `&` as an argument name to indicate yielding method.
Lint/MissingBlockArgument: src/placeos-build/client.cr#L35
Missing anonymous block argument. Use `&` as an argument name to indicate yielding method.
Lint/MissingBlockArgument: src/placeos-build/client.cr#L45
Missing anonymous block argument. Use `&` as an argument name to indicate yielding method.
build / Build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, docker/setup-qemu-action@v2, docker/setup-buildx-action@v2, docker/login-action@v2, docker/build-push-action@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Style/QueryBoolMethods: src/placeos-build/cli.cr#L33
Consider using 'getter?' for 'version'
Style/QueryBoolMethods: src/placeos-build/cli.cr#L37
Consider using 'getter?' for 'environment'
Style/QueryBoolMethods: src/placeos-build/cli/server.cr#L18
Consider using 'getter?' for 'routes'
Style/QueryBoolMethods: src/placeos-build/digest/cli.cr#L106
Consider using 'getter?' for 'verbose'
Style/PredicateName: src/placeos-build/cli/build.cr#L104
Favour method name 'driver?' over 'is_driver?'
Style/QueryBoolMethods: src/placeos-build/cli/build.cr#L26
Consider using 'getter?' for 'strict_driver_info'
Style/QueryBoolMethods: src/placeos-build/cli/build.cr#L29
Consider using 'getter?' for 'discover'
Style/PredicateName: src/placeos-build/driver_store/s3.cr#L173
Favour method name 'elf?' over 'is_elf?'