fix: request in register alarm #89

Pic-me-Pic-me · Jun 18, 2023 · bff6880 · bff6880
1 parent 5e36ba1
commit bff6880
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 3 deletions.
diff --git a/src/constants/responseMessage.ts b/src/constants/responseMessage.ts
@@ -98,5 +98,6 @@ export default {
     //alarm
     PUSH_NOTIFICATION_SUCCESS: "알람 전송 성공",
     PUSH_NOTIFICATION_FALED: "알람 전송 실패",
+    PUSH_NOTIFICATION_REGISTER_SUCCESS: "유저 구독 성공",
     PUSH_NOTIFICATION_REGISTER_FALED: "유저 구독 실패",
 };
diff --git a/src/controller/alarmController.ts b/src/controller/alarmController.ts
@@ -42,12 +42,16 @@ const register = async (req: Request, res: Response, next: NextFunction) => {
         return next(new PicmeException(sc.BAD_REQUEST, false, rm.BAD_REQUEST));
     }
 
+    const userId = req.body.userId;
+
+    if (!userId) return next(new PicmeException(sc.UNAUTHORIZED, false, rm.INVALID_TOKEN));
+
     const alarmRegisterDTO: AlarmRegisterDTO = req.body;
 
     try {
         await alarmService.register(alarmRegisterDTO);
 
-        return res.status(sc.OK).send(success(sc.OK, rm.PUSH_NOTIFICATION_SUCCESS));
+        return res.status(sc.OK).send(success(sc.OK, rm.PUSH_NOTIFICATION_REGISTER_SUCCESS));
     } catch (e) {
         return next(e);
     }

diff --git a/src/middlewares/auth.ts b/src/middlewares/auth.ts
@@ -5,7 +5,14 @@ import { fail } from "../constants/response";
 import tokenType from "../constants/tokenType";
 import jwtHandler from "../modules/jwtHandler";
 
-const skipAuthPath = ["/sticker", "/auth", "/user/name", "/user/email", "/vote/common", "/alarm"];
+const skipAuthPath = [
+    "/sticker",
+    "/auth",
+    "/user/name",
+    "/user/email",
+    "/vote/common",
+    "/alarm/push",
+];
 const uploadPath = "/vote";
 
 export default async (req: Request, res: Response, next: NextFunction) => {

diff --git a/src/router/alarmRouter.ts b/src/router/alarmRouter.ts
@@ -14,7 +14,7 @@ router.post(
 //register notification
 router.post(
     "/register",
-    [body("userId").notEmpty(), body("endpoint").notEmpty(), body("keys").notEmpty()],
+    [body("endpoint").notEmpty(), body("expirationTime"), body("keys").notEmpty()],
     alarmController.register
 );