Silently fail to avoid sending headers early (#80)

* Silently fail to avoid sending headers early * Update dependencies
PhpGt · Jan 12, 2021 · a890bad · a890bad
1 parent ffd186b
commit a890bad
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 13 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/src/Session.php b/src/Session.php
@@ -36,6 +36,7 @@ public function __construct(
 			$config["save_path"] ?? self::DEFAULT_SESSION_PATH
 		);
 		$sessionName = $config["name"] ?? self::DEFAULT_SESSION_NAME;
+		$sessionStartAttempts = 0;
 
 		do {
 			$success = @session_start([
@@ -49,10 +50,11 @@ public function __construct(
 			]);
 
 			if(!$success) {
-				session_destroy();
+				$sessionStartAttempts++;
+				@session_destroy();
 			}
 		}
-		while(!$success);
+		while(!$success && $sessionStartAttempts <= 1);
 
 		$this->sessionHandler->open($sessionPath, $sessionName);
 		$this->store = $this->readSessionData() ?: null;