Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to WPILib beta 2 #1588

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Update to WPILib beta 2 #1588

merged 3 commits into from
Nov 21, 2024

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Nov 17, 2024 •
edited
Loading

Resolves #1547.

@Gold856 Gold856 force-pushed the wpilib-beta-2 branch 2 times, most recently from a7180f8 to 4b0c0f0 Compare November 19, 2024 05:57
@mcm001
Copy link
Contributor

mcm001 commented Nov 19, 2024

Incredible. it's all red.

@Gold856 Gold856 marked this pull request as ready for review November 20, 2024 08:52
@Gold856 Gold856 requested a review from a team as a code owner November 20, 2024 08:52
@Gold856 Gold856 marked this pull request as draft November 20, 2024 09:16
@spacey-sooty
Copy link
Member

I don't think upgrading Gradle will work till we remove runtime detector usage, when I tried it triggered deprecation warnings because of it

@Gold856
Copy link
Contributor Author

Gold856 commented Nov 20, 2024

I've already been getting deprecation warnings related to RuntimeDetector; I don't think that's related.

@spacey-sooty
Copy link
Member

spacey-sooty commented Nov 20, 2024 •
edited
Loading

They were making CI fail when I tried to update Gradle #1547 nvm I reread the error and I'm trolling.

@Gold856
Copy link
Contributor Author

Gold856 commented Nov 20, 2024

There are zero CI failures related to RuntimeDetector.

@spacey-sooty
Copy link
Member

There are zero CI failures related to RuntimeDetector.

Yeah I'm going crazy mb

@Gold856 Gold856 force-pushed the wpilib-beta-2 branch 2 times, most recently from d7c69a2 to 8ec6db8 Compare November 21, 2024 03:37
@Gold856 Gold856 marked this pull request as ready for review November 21, 2024 04:37
mcm001
mcm001 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so many changes to the docs? But yeah send it whatever

@mcm001 mcm001 added this pull request to the merge queue Nov 21, 2024
Merged via the queue into PhotonVision:master with commit 08b4bd1 Nov 21, 2024
35 checks passed
@Gold856
Copy link
Contributor Author

Gold856 commented Nov 21, 2024

GradleRIO updated to Gradle 8.11, so I needed to make the same update. The Doxygen Gradle plugin needed an update to work with Gradle 8.11. And since I was updating Doxygen anyways, I decided to update the CSS file so the docs look good (icons were cutoff with the old CSS file and new Doxygen).

@Gold856 Gold856 deleted the wpilib-beta-2 branch November 21, 2024 05:06
@mcm001
Copy link
Contributor

mcm001 commented Nov 21, 2024

Thanks! Nobody reads the docs anyways, but I trusted the new docs look good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gold856 @mcm001 @spacey-sooty