Update Subnautica (use latest Wine devel version, disable nvapi workaround, set environment variables) #1197

Zemogiter · 2020-01-10T18:01:44Z

Description

Tried playing this game today. It crashed with standard "Subnautica.exe stoped working" error. before displaying anything. Tried disabling any mods and QModManager. Still crashes. Reinstalling verbs via winetricks. Still crashes. Changing wine version from 4.0.3 to 5.0-rc3 finally did the trick.

What works

Game installation, starting the game, gameplay itself

What was not tested

~~Gameplay, will have some time after weekend to see if changes to the script affect the game in any negative way~~Nothing

Test

Operating system (and linux kernel version): Ubuntu 19.10
Hardware (GPU/CPU): GTX 1080 ti, i7-7700K

Ready for review

Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
json-align and eslint run according to the documentation.
Codacy and travis checked.

Zemogiter · 2020-01-12T13:54:39Z

Ready for review.

ImperatorS79 · 2020-01-13T12:33:00Z

Applications/Games/Subnautica/Steam/script.js

            )
        );
    })
-    .gameOverlay(false);
+    .gameOverlay(false)
+    .environment('{"DXVK_CONFIG_FILE": "dxvkConfigFile", "STAGING_SHARED_MEMORY": "0", "WINEESYNC": "1"}')


This will simply put the string dxvkConfigFile in the environment variable. Even with the right syntax, there is no dxvkConfigFile variable defined. The variable is only present in the lambda function code you pass to .postInstall. This will not work.

Should I change it to wine.prefixDirectory() + "/drive_c/dxvk.conf"?

You cannot access wine is .environment since it is not defined. The best would be to modify .environment() function to get a lambda (wine) => {} so that .environment could call that lambda by sending it the wine object and get the string for the environment.

Like this?

environment(environment) { this._environment = environment; lambda(wine) => {}; return this; }

Something like this:

environment(environmentFunc) { this._environment = environmentFunc(this.wine()); return this; }

and you would call it like this

.environtment((wine) => { //do things to obtain the jsonString return jsonString; })

OK now I get this error:

Error: The argument of environment() should be a function ! at <js> environment(Unnamed:139:3777-3845) at <js> :program(Unnamed:14-45:689-1859) at org.graalvm.polyglot.Context.eval(Context.java:370) at org.phoenicis.scripts.engine.implementation.PolyglotScriptEngine.evalAndReturn(PolyglotScriptEngine.java:73) at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35) at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834)

[ERROR] org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - java.lang.ClassCastException: class java.lang.String cannot be cast to class org.graalvm.polyglot.Value (java.lang.String is in module java.base of loader 'bootstrap'; org.graalvm.polyglot.Value is in unnamed module of loader java.net.URLClassLoader @76c548f) at org.phoenicis.javafx.components.application.skin.ApplicationInformationPanelSkin.lambda$installScript$7(ApplicationInformationPanelSkin.java:235) at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35) at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834) [WARNING] java.lang.ClassCastException: class java.lang.String cannot be cast to class org.graalvm.polyglot.Value (java.lang.String is in module java.base of loader 'bootstrap'; org.graalvm.polyglot.Value is in unnamed module of loader java.net.URLClassLoader @76c548f) at org.phoenicis.javafx.components.application.skin.ApplicationInformationPanelSkin.lambda$installScript$7 (ApplicationInformationPanelSkin.java:235) at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval (PhoenicisInteractiveScriptSession.java:35) at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1 (BackgroundScriptInterpreter.java:45) at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1128) at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:628) at java.lang.Thread.run (Thread.java:834) Error: The argument of environment() should be a function ! at <js> environment(Unnamed:139:3777-3845) at <js> :program(Unnamed:14-45:689-1859) at org.graalvm.polyglot.Context.eval(Context.java:370) at org.phoenicis.scripts.engine.implementation.PolyglotScriptEngine.evalAndReturn(PolyglotScriptEngine.java:73) at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35) at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834)

What is the argument of environment in your script ?

@ImperatorS79 '{"DXVK_CONFIG_FILE": "dxvkConfigFile", "STAGING_SHARED_MEMORY": "0", "WINEESYNC": "1"}'

It should be:

.environment((wine) => { const dxvkConfigFile = wine.prefixDirectory() + "/drive_c/dxvk.conf"; return '{"DXVK_CONFIG_FILE": "${dxvkConfigFile}", "STAGING_SHARED_MEMORY": "0", "WINEESYNC": "1"}'; })

or something like this for the template string.

It's done but wine.log still shows info: DXGI: NvAPI workaround enabled, reporting AMD GPU

Added a proper variable reading in environment

ImperatorS79 · 2020-01-14T11:37:34Z

@Zemogiter You should do a PR about the environment modification first. (Because it will be needed to modify each QuickScript + each script using environment)

Zemogiter · 2020-01-14T11:38:12Z

@Zemogiter You should do a PR about the environment modification first. (Because it will be needed to modify each QuickScript + each script using environment)

I know.

Zemogiter · 2020-01-14T11:56:57Z

Blocked until #1198 is merged.

Using proper json format

plata · 2020-04-06T10:20:33Z

Applications/Games/Subnautica/Steam/script.js

-    .gameOverlay(false);
+    .gameOverlay(false)
+    .environment((wine) => {
+        const dxvkConfigFile = wine.prefixDirectory() + "/drive_c/dxvk.conf";


Issue found: 'dxvkConfigFile' is assigned a value but never used.

Zemogiter · 2020-05-12T18:18:18Z

I'm receiving the same error as in #1119 (comment)

Zemogiter added 2 commits January 10, 2020 18:56

Update script.js

b45e8f0

Update script.js

3c5eab4

ImperatorS79 requested changes Jan 13, 2020

View reviewed changes

plata changed the title ~~Update Subnautica, using latest dev Wine version, disabling nvapi workaround, introduce environment values~~ Update Subnautica (use latest Wine devel version, disable nvapi workaround, set environment variables) Jan 13, 2020

Update script.js

184237f

Added a proper variable reading in environment

Update script.js

2bc17e9

Zemogiter mentioned this pull request Jan 14, 2020

Change .environment to a function that returns variables instead of strings #1198

Draft

3 tasks

PhoenicisOrg deleted a comment from ImperatorS79 Jan 14, 2020

PhoenicisOrg deleted a comment from Zemogiter Jan 14, 2020

Update script.js

6bc51ad

PhoenicisOrg deleted a comment from Zemogiter Feb 15, 2020

Update script.js

ff57461

Using proper json format

plata reviewed Apr 6, 2020

View reviewed changes

Update script.js

9c8173b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Subnautica (use latest Wine devel version, disable nvapi workaround, set environment variables) #1197

Update Subnautica (use latest Wine devel version, disable nvapi workaround, set environment variables) #1197

Zemogiter commented Jan 10, 2020 •

edited

Loading

Zemogiter commented Jan 12, 2020

ImperatorS79 Jan 13, 2020 •

edited

Loading

Zemogiter Jan 13, 2020

ImperatorS79 Jan 13, 2020

Zemogiter Jan 13, 2020

ImperatorS79 Jan 13, 2020 •

edited

Loading

Zemogiter Jan 14, 2020

ImperatorS79 Jan 14, 2020

Zemogiter Jan 14, 2020

ImperatorS79 Jan 14, 2020

Zemogiter Jan 14, 2020

ImperatorS79 commented Jan 14, 2020

Zemogiter commented Jan 14, 2020

Zemogiter commented Jan 14, 2020

plata Apr 6, 2020

Zemogiter commented May 12, 2020

Update Subnautica (use latest Wine devel version, disable nvapi workaround, set environment variables) #1197

Are you sure you want to change the base?

Update Subnautica (use latest Wine devel version, disable nvapi workaround, set environment variables) #1197

Conversation

Zemogiter commented Jan 10, 2020 • edited Loading

Description

What works

What was not tested

Test

Ready for review

Zemogiter commented Jan 12, 2020

ImperatorS79 Jan 13, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ImperatorS79 Jan 13, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ImperatorS79 commented Jan 14, 2020

Zemogiter commented Jan 14, 2020

Zemogiter commented Jan 14, 2020

Choose a reason for hiding this comment

Zemogiter commented May 12, 2020

Zemogiter commented Jan 10, 2020 •

edited

Loading

ImperatorS79 Jan 13, 2020 •

edited

Loading

ImperatorS79 Jan 13, 2020 •

edited

Loading