Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manylinux #86

Merged
merged 1 commit into from
Oct 26, 2023
Merged

manylinux #86

merged 1 commit into from
Oct 26, 2023

Conversation

PhilipDeegan
Copy link
Owner

@PhilipDeegan PhilipDeegan commented Oct 26, 2023

Summary by CodeRabbit

  • Chore: Updated the release process in our workflow. The release job now waits for both the standard build and a new, additional Linux-specific build to complete before it starts. This change ensures that our software is thoroughly tested and compatible across multiple platforms before release, enhancing reliability for all users.

@coderabbitai
Copy link

coderabbitai bot commented Oct 26, 2023

Walkthrough

The change in the workflow file introduces a new dependency for the release job. Now, it will only run after the successful completion of both build and build_many_linux jobs, ensuring a more robust release process.

Changes

File Summary
.github/workflows/release.yml The release job now depends on both build and build_many_linux jobs.

🐇

In the land of code, where the scripts play,

A change was made, to brighten the day.

Two jobs now hold hands, in a merry dance,

Ensuring release has a solid stance. 🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

@PhilipDeegan PhilipDeegan merged commit e309ce4 into master Oct 26, 2023
3 of 4 checks passed
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 2a10bc1 and 779f278.
Files selected for processing (1)
  • .github/workflows/release.yml (1} hunks)
Additional comments: 1
.github/workflows/release.yml (1)
  • 91-91: The needs field of the release job has been updated to include build_many_linux in addition to build. This means that the release job will now wait for both build and build_many_linux jobs to complete successfully before it starts. This change is consistent with the PR summary and seems to be aimed at ensuring that the manylinux wheels are built before the release job starts. However, please verify that the build_many_linux job is configured to run and complete successfully before the release job is triggered.
-    needs: build
+    needs: [build, build_many_linux]
Committable suggestion (Beta)
  release:
    name: "Prelease"
    needs: [build, build_many_linux]
    runs-on: ubuntu-latest
    steps:
      - uses: actions/download-artifact@v3

@PhilipDeegan PhilipDeegan deleted the manylinux branch November 19, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant