Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manylinux mkn artifact #83

Merged
merged 1 commit into from
Oct 26, 2023
Merged

manylinux mkn artifact #83

merged 1 commit into from
Oct 26, 2023

Conversation

PhilipDeegan
Copy link
Owner

@PhilipDeegan PhilipDeegan commented Oct 26, 2023

Summary by CodeRabbit

  • New Feature: Introduced a new "many-linux" build process, enhancing compatibility with a wider range of Linux distributions.
  • Improvement: Updated key components of our build workflows (actions/checkout and actions/upload-artifact) to their latest versions, potentially introducing new features and bug fixes to improve the reliability of our build process.
  • Bug Fix: Resolved an interference issue in the Windows build process, enhancing the stability and reliability of Windows builds.
  • Improvement: Enhanced artifact management in the release process, improving the efficiency and reliability of our software releases.

@coderabbitai
Copy link

coderabbitai bot commented Oct 26, 2023

Walkthrough

This pull request primarily updates the GitHub Actions workflows, upgrading actions/checkout and actions/upload-artifact from v2 to v3 across multiple files. It also introduces a new workflow for manylinux builds and resolves an interference issue in the Windows build.

Changes

File Summary
.github/workflows/build_many_linux.yml New workflow for manylinux builds, running on pull requests to master.
.github/workflows/build_nix.yml, .github/workflows/build_osx.yml, .github/workflows/release.yml Updated actions/checkout and actions/upload-artifact from v2 to v3.
.github/workflows/build_win.yml Updated actions and resolved an interference issue with cl/link.exe.
.github/workflows/release.yml Added a new job for manylinux builds and improved artifact management.

🐇💻

In the land of code, where the shadows lie,

A rabbit hops, under the cloudless sky.

With each soft thump, an action's done,

A build is made, a race is won.

The workflows flow, like a river's course,

Guided by the rabbit, with gentle force.

So raise your carrots, to the sky,

For the code rabbit's work, is nigh. 🥕🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 0320492 and d41f5a8.
Files selected for processing (5)
  • .github/workflows/build_many_linux.yml (1} hunks)
  • .github/workflows/build_nix.yml (2} hunks)
  • .github/workflows/build_osx.yml (2} hunks)
  • .github/workflows/build_win.yml (2} hunks)
  • .github/workflows/release.yml (3} hunks)
Files skipped from review due to trivial changes (5)
  • .github/workflows/build_many_linux.yml
  • .github/workflows/build_nix.yml
  • .github/workflows/build_osx.yml
  • .github/workflows/build_win.yml
  • .github/workflows/release.yml

@PhilipDeegan PhilipDeegan merged commit dd00f47 into master Oct 26, 2023
4 checks passed
@PhilipDeegan PhilipDeegan deleted the manylinux branch October 26, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant