Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTime::Format::* does not have fromat_timestamp_without_timezone m… #137

Open
wants to merge 1 commit into
base: maint/0.0828xx
Choose a base branch
from

Conversation

KES777
Copy link

@KES777 KES777 commented Oct 28, 2020

FIXES: RT133622

https://metacpan.org/pod/DateTime::Format::Oracle
https://metacpan.org/pod/DateTime::Format::Pg

Has method 'format_timestamp_with_time_zone' so we should rename

@abraxxa
Copy link
Contributor

abraxxa commented Nov 2, 2020

So there is no test for this, neither for Oracle nor for PostgreSQL so this was unnoticed for so many years?
I guess that it was a typo in the initial implementation.
DateTime::Format::Oracle has it wrong in its Changes file as well, was added in 0.05.
Looks like nobody is storing timezones, at least we don't and convert to/from UTC.

Please add at least one test case so it can't happen again, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants