Skip to content

Commit

Permalink
SQLA 1.79 shipped - revert tempextlib hack from d0435d7
Browse files Browse the repository at this point in the history
  • Loading branch information
ribasushi committed Sep 25, 2014
1 parent ee20ecf commit 3135108
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 77 deletions.
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,3 @@ t/var/
*~
maint/.Generated_Pod
examples/Schema/db

lib/DBIx/Class/_TempExtlib
36 changes: 1 addition & 35 deletions Makefile.PL
Original file line number Diff line number Diff line change
Expand Up @@ -15,40 +15,6 @@ BEGIN {
$Module::Install::AUTHOR = 0 if (grep { $ENV{"PERL5_${_}_IS_RUNNING"} } (qw/CPANM CPANPLUS CPAN/) );
}

##
## TEMPORARY (and non-portable)
## Get trial SQLA
##
BEGIN {
my $target_libdir = 'lib/DBIx/Class/_TempExtlib';

if ( ($Module::Install::AUTHOR or $ENV{TRAVIS}) and ! $ENV{MAKELEVEL} ) {

`rm -rf $target_libdir`;
`mkdir $target_libdir`;
for (
[ 'SQL-Abstract' => 'master' ],
) {
my $tdir = "/tmp/dbictemplib/$_->[0]/";

`rm -rf $tdir`;

`GIT_SSH=maint/careless_ssh.bash git clone --bare --quiet --branch=$_->[1] --depth=1 git://git.shadowcat.co.uk/dbsrgits/$_->[0] $tdir`;
printf "\nIncluding %s git rev %s\n",
$_->[0],
scalar `GIT_DIR=$tdir git rev-parse $_->[1]`,
;
`git archive --format=tar --remote=file://$tdir $_->[1] lib/ | tar --strip-components=1 -xC $target_libdir`;

#`rm -rf $tdir`;
}

unshift @INC, $target_libdir;

no_index directory => $target_libdir;
}
}

name 'DBIx-Class';
version_from 'lib/DBIx/Class.pm';
perl_version '5.008001';
Expand Down Expand Up @@ -96,7 +62,7 @@ my $runtime_requires = {
'namespace::clean' => '0.24',
'Path::Class' => '0.18',
'Scope::Guard' => '0.03',
'SQL::Abstract' => '1.78',
'SQL::Abstract' => '1.79',
'Try::Tiny' => '0.07',

# Technically this is not a core dependency - it is only required
Expand Down
31 changes: 0 additions & 31 deletions lib/DBIx/Class/_Util.pm
Original file line number Diff line number Diff line change
Expand Up @@ -4,37 +4,6 @@ package # hide from PAUSE
use warnings;
use strict;

# Temporary - tempextlib
use namespace::clean;
BEGIN {
require Module::Runtime;
require File::Spec;

# There can be only one of these, make sure we get the bundled part and
# *not* something off the site lib
for (qw(
DBIx::Class::SQLMaker
SQL::Abstract
SQL::Abstract::Test
)) {
if ($INC{Module::Runtime::module_notional_filename($_)}) {
die "\nUnable to continue - a part of the bundled templib contents "
. "was already loaded (likely an older version from CPAN). "
. "Make sure that @{[ __PACKAGE__ ]} is loaded before $_\n\n"
;
}
}

our ($HERE) = File::Spec->rel2abs(
File::Spec->catdir( (File::Spec->splitpath(__FILE__))[1], '_TempExtlib' )
) =~ /^(.*)$/; # screw you, taint mode

die "TempExtlib $HERE does not seem to exist - perhaps you need to run `perl Makefile.PL` in the DBIC checkout?\n"
unless -d $HERE;

unshift @INC, $HERE;
}

use constant SPURIOUS_VERSION_CHECK_WARNINGS => ($] < 5.010 ? 1 : 0);

BEGIN {
Expand Down
3 changes: 0 additions & 3 deletions maint/careless_ssh.bash

This file was deleted.

3 changes: 0 additions & 3 deletions t/53lean_startup.t
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,6 @@ BEGIN {
Class::Accessor::Grouped
Class::C3::Componentised
SQL::Abstract
Module::Runtime
File::Spec
));

require DBICTest::Schema;
Expand Down
1 change: 0 additions & 1 deletion xt/footers.t
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ find({

return unless -f $fn;
return unless $fn =~ / \. (?: pm | pod ) $ /ix;
return if $fn =~ qr{\Qlib/DBIx/Class/_TempExtlib/};

my $data = do { local (@ARGV, $/) = $fn; <> };

Expand Down
2 changes: 0 additions & 2 deletions xt/podcoverage.t
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,6 @@ my $exceptions = {
/]
},

'DBIx::Class::_TempExtlib*' => { skip => 1 },

'DBIx::Class::Admin::*' => { skip => 1 },
'DBIx::Class::ClassResolver::PassThrough' => { skip => 1 },
'DBIx::Class::Componentised' => { skip => 1 },
Expand Down

0 comments on commit 3135108

Please sign in to comment.