re-enable (feature guarded) switch and re-enable smartmatch with a new feature guard #22766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 23f3171.
This reverts commit 51238ec.
This reverts commit 18b5dc4.
This reverts commit 901bf8b.
This reverts commit ffb20d9.
This reverts commit 149bea6.
This reverts commit cb2167d.
This reverts commit dff5181.
interestingly the TOKEN(0) line here isn't exercised by the test suite, I haven't tracked down what it would take to exercise it. The deprecation messages will be removed in an upcoming commit
The deprecation warnings don't appear to have had any tests.
book
previously requested changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes any deprecation warnings and documentation.
Fixes #22752