Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document when backwards-compatibility features are disabled by default #22448

Closed
wants to merge 1 commit into from

Conversation

book
Copy link
Contributor

@book book commented Jul 30, 2024

No description provided.

@book book force-pushed the book/feature-doc-patch branch from c98bed0 to dce9f54 Compare July 30, 2024 14:51
@book
Copy link
Contributor Author

book commented Jul 30, 2024

I had forgotten feature.pm was a generated file... 😅

@book book requested a review from haarg July 30, 2024 14:52
@jkeenan
Copy link
Contributor

jkeenan commented Jul 30, 2024

I had forgotten feature.pm was a generated file... 😅

It apparently still needs a version bump; see test failures. I suspect this bump goes in whatever *.pl file generates it.

@haarg
Copy link
Contributor

haarg commented Jul 30, 2024

These changes aren't really correct. The features are not disabled by default in Perl 5.36. They are disabled by the 5.36 feature bundle.

@book
Copy link
Contributor Author

book commented Jul 30, 2024

These changes aren't really correct. The features are not disabled by default in Perl 5.36. They are disabled by the 5.36 feature bundle.

Does this sound better (and more correct)?

This feature is disabled starting with the C<:5.36> feature bundle.

I want to convey clearly that it's going to be disabled in all bundles after :5.36.

@book book force-pushed the book/feature-doc-patch branch from dce9f54 to e189945 Compare July 31, 2024 07:27
@book
Copy link
Contributor Author

book commented Jul 31, 2024

Actually, I have more changes to this manual page, so I'll bundle them in a single pull request.

@book book closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants