Define and use typed xvREFCNT_inc() macros #22416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonerd
added
the
squash-before-merge
leonerd
changed the title
leonerd
force-pushed
the
typed-refcnt-macros
branch
from
22f43d4 to
6fe12e9
Compare
khwilliamson
approved these changes
Jul 21, 2024
Leont
approved these changes
Jul 21, 2024
Create specific macros for incrementing the refcount of an AV, CV, GV or HV, returning a typed pointer to avoid the caller needing to cast the result. This yields neater easier-to-read code. While not implemented here, this gives an opportunity to add an `assert()` check on the SvTYPE of the structure being adjusted, for extra debug checking during debugging builds.
leonerd
force-pushed
the
typed-refcnt-macros
branch
from
6fe12e9 to
347434c
Compare
|
force-pushed to squash all the commits into one, and give them a better commit message |
leonerd
removed
the
squash-before-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These new macros take and return pointers to specific subtypes of SV, rather than the generic SvREFCNT_inc() family. As such they avoid needing to cast the result back.
This results in neater, easier-to-read code in a variety of places. It removes many entirely-redundant calls to the
MUTABLE_xVmacro. It also leaves a space for possible future expansion later on by having the macros additionally assert on theSvTYPEin-DDEBUGGINGbuilds.