-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File::Spec::{Unix,OS2}->path(): Keep trailing empty PATH elements #22403
Conversation
I've amended the commits to ensure all |
This looks good to me, but I'd like to see #22404 merged in first. |
GH #22404 has been merged in to blead. That caused GitHub to append a I think I'll let the GH CI testing proceed before taking further action. In the meantime, if there is anyone else who wants to look over this pull request, please do so. Thanks. |
@tonycoz or @book, can either of you look at the code changes being requested here and approve? At that point, I'll deal with the merge problems. Thanks. |
This comment has been minimized.
This comment has been minimized.
Fixes #22346 by ensuring that trailing PATH elements are maintained *on Unix*
keeps empty trailing PATH segments on OS2. I'm unsure of the OS2 semantics regarding PATH, so this is in a seperate commit in case it needs to be reverted.
@jkeenan I've rebased onto |
Thanks for that legwork. I've approved this commit and self-assigned. I'll allow for 2 or 3 days for other committers to approve, and then proceed to merge unless there's an objection. |
Fixes #22346 by ensuring that trailing PATH elements are maintained on
Unix and OS2