vmsify: don't add dot when drop dots feature is active #22348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a feature to omit the trailing dot on files with no extension is enabled, we have been actually appending a dot since the huge omnibus patch f7ddb74 19 years ago. The implementation may have been done backwards from its intention, or it may have intended to add the dot only when it would get removed on a round trip back through unixify. Which raises the question why add it at all? So don't. There are relatively few situations where the absence of the dot can cause trouble, notably when a specific application has its own default file type that we want to override. But there are lots of situations where the presence of a dot causes trouble, such as File::Temp's confusion when its template that should end in 'XXXX' gets 'XXXX.' instead. There is no change to default behavior here, only the behavior when DECC$READDIR_DROPDOTNOTYPE is present in the environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a feature to omit the trailing dot on files with no extension is enabled, we have been actually appending a dot since the huge omnibus patch f7ddb74 19 years ago. The implementation may have been done backwards from its intention, or it may have intended to add the dot only when it would get removed on a round trip back through unixify. Which raises the question why add it at all? So don't.
There are relatively few situations where the absence of the dot can cause trouble, notably when a specific application has its own default file type that we want to override. But there are lots of situations where the presence of a dot causes trouble, such as File::Temp's confusion when its template that should end in 'XXXX' gets 'XXXX.' instead.
There is no change to default behavior here, only the behavior when DECC$READDIR_DROPDOTNOTYPE is present in the environment.