Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlapi: Combine all forms of is_utf8_fixed_width_buf #22325

Merged
merged 1 commit into from
Jun 29, 2024
Merged

perlapi: Combine all forms of is_utf8_fixed_width_buf #22325

merged 1 commit into from
Jun 29, 2024

Conversation

khwilliamson
Copy link
Contributor

No description provided.

jkeenan
jkeenan reviewed Jun 23, 2024
View reviewed changes
Copy link
Contributor

@jkeenan jkeenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output from perldoc pod/perlapi.pod once branch is built LGTM. Since content has been reworded, should get additional review.

@jkeenan
Copy link
Contributor

jkeenan commented Jun 23, 2024

@khwilliamson, how does this p.r. relate to what we applied in 72f896dfba?

commit 72f896dfba26f0169bedfc22ce7001aa7ec84147 (HEAD -> gh-22325-khwilliamson-fixed_width_api-20240623)
Author:     Karl Williamson <[email protected]>
AuthorDate: Mon Jun 10 15:44:59 2024 -0600
Commit:     James E Keenan <[email protected]>
CommitDate: Sun Jun 23 17:21:52 2024 -0400

    perlapi: Combine all forms of is_utf8_fixed_width_buf

@khwilliamson
Copy link
Contributor Author

@jkeenan that commit isn't blead.

@khwilliamson khwilliamson merged commit b1a513f into Perl:blead Jun 29, 2024
29 checks passed
@khwilliamson khwilliamson deleted the fixed_width_api branch June 29, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkeenan jkeenan jkeenan left review comments

@tonycoz tonycoz tonycoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khwilliamson @jkeenan @tonycoz