Add lock_definitions.h #22283
Closed
Add lock_definitions.h #22283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkeenan
reviewed
Jun 16, 2024
This file is intended to insulate C code from thread issues, when used as directed.
khwilliamson
force-pushed
the
lock_definitions.h
branch
from
0a50c29 to
167d080
Compare
tonycoz
reviewed
Jun 24, 2024
| if $entry->{locks} || $entry->{categories}; | ||
| print $l <<~EOT; | ||
| #${dindent}define ${USE}_LOCK \\ | ||
| #${dindent} error_${use}_not_suitable_for_multi-threaded_operation |
There was a problem hiding this comment.
Why does this generate:
# error_foo_not suitable...
rather than
# error foo_not suitable...
?
The first may produce an error, but it might not include the text of the symbol.
The second will produce the requested message, though it might be better to quote it, which will prevent macro replacement, allowing you to avoid the need for all_the_underscores.
tonycoz
reviewed
Jun 24, 2024
jkeenan
added
Closable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is intended to insulate C code from thread issues, when used as directed.