Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/run/todo.t: Avoid "Odd number of elements" warning #22275

Closed

Conversation

jkeenan
Copy link
Contributor

@jkeenan jkeenan commented Jun 12, 2024

The third argument to t/test.pl's fresh_perl_is() function is an anonymous hash; therefore, it must have an even number of elements. In this case, that even number would be 0. As it stood, we were getting this warning:

"Odd number of elements in anonymous hash at run/todo.t line 30."

@jkeenan jkeenan requested a review from khwilliamson June 12, 2024 19:47
The third argument to t/test.pl's fresh_perl_is() function is an
anonymous hash; therefore, it must have an even number of elements.  In
this case, that even number would be 0.  As it stood, we were getting
this warning:

"Odd number of elements in anonymous hash at run/todo.t line 30."
@jkeenan jkeenan force-pushed the avoid-odd-elements-warning-20240612 branch from 0279375 to 70ae893 Compare June 12, 2024 19:51
t/run/todo.t Show resolved Hide resolved
jkeenan added a commit that referenced this pull request Jun 13, 2024
Per comment from author in #22275, the
code should have read '{ eval $switches }' as in other test files.

Making this correction eliminates the "Odd number of elements in
anonymous hash" warning which was the concern in that pull request.

Fixes GH #22275.
@jkeenan jkeenan closed this Jun 13, 2024
@jkeenan jkeenan deleted the avoid-odd-elements-warning-20240612 branch June 13, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants