Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpan/Encode/Byte/Makefile.PL: ensure build reproducibility #22172

Closed
wants to merge 1 commit into from

Conversation

kanavin
Copy link

@kanavin kanavin commented Apr 25, 2024

Sort the Encode::Byte byte_t.fnm file output
(and the makefile depends whilst there for good measure).

Otherwise the output is non-deterministic and can change from one build to the next.

Sort the Encode::Byte byte_t.fnm file output
(and the makefile depends whilst there for good measure).

Otherwise the output is non-deterministic and can change from
one build to the next.
@jkeenan
Copy link
Contributor

jkeenan commented Apr 25, 2024

Sort the Encode::Byte byte_t.fnm file output (and the makefile depends whilst there for good measure).

Otherwise the output is non-deterministic and can change from one build to the next.

While this change set looks acceptable, you will have to submit it at https://github.com/dankogai/p5-encode. Encode is a library maintained on CPAN for multiple versions of perl and shipped with the core distribution. So the upstream maintainer has to verify that your proposed changes will work with older versions of Encode. Please file your merge request at that URL.

Marking this ticket send-to-cpan and closing here.

@jkeenan jkeenan closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants