Fix stringified IV_MIN sometimes unintentionally treated as NV #22171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For !NV_PRESERVES_UV case (e.g. IV and NV are both 64-bit, as in
typical x86_64 build), sv_2nv_flags() used to cache only NV for
stringified IV_MIN ("-9223372036854775808" in such case).
This leads such string to be treated as (possibly unintentionally
rounded) NV in subsequent references:
$ perl -wle 'my $x = my $y = "-9223372036854775808";
my $z = $x + 1.23; print $x + 0; print $y + 0'
-9.22337203685478e+18
-9223372036854775808
$
This change avoid this by not treating IV_MIN specially,
with new macros added in b9b8c7d.
t/op/numconvert.t: Added tests for this.
tonycoz
approved these changes
Apr 25, 2024
Tux
approved these changes
Apr 27, 2024
leonerd
reviewed
May 2, 2024
leonerd
added
the
defer-next-dev
jkeenan
removed
the
defer-next-dev
Since blead is now open, I'll take this ticket for the purpose of merging it in 2 or 3 days. So if anyone has a new objection, please speak up! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String representation of IV_MIN (
"-9223372036854775808"in typical 64bit build) is expected to be treated as IV in numeric context, but current perl sometimes treat it as NV.In
!NV_PRESERVES_UVcase (e.g. IV and NV are both 64-bit, as in typical x86_64 build), if such string is once referred in NV context (withsv_2nv_flags()), it will be unexpectedly treated as NV in subsequent numeric references:This change will hopefully resolve this.