_PC_CHOWN_RESTRICTED can only be used via pathconf/fpathconf, not sysconf #22161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauke
changed the title
|
I had some issues with porting tests failing, so I made some minor changes and force-pushed the PR branch. fingers crossed |
mauke
approved these changes
Apr 21, 2024
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Apr 30, 2024
The wrong function was being used (POSIX::sysconf) to determine the value of _PC_CHOWN_RESTRICTED, neutering the security feature. Migrate to POSIX::pathconf, as is now recommended by the Perl documentation (Perl/perl5#22161). This patch hasn't yet been merged upstream into File-Temp, but the documentation change rectifying the error in Perl itself has been merged, so I'm confident it's the right thing to do. Closes: https://bugs.gentoo.org/930949 Signed-off-by: Sam James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation regarding availability of chown (
perldoc -f chown) incorrectly uses the sysconf() function rather than the pathconf() function along with a path._PC* can only be used as parameters to pathconf()/fpathconf(). Only _SC* values can be used against sysconf().
Cannot speak to other systems but on all linux systems the original code would be returning the value for "_SC_TZNAME_MAX, The maximum number of bytes in a timezone name."