Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detector Improvements #67

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Detector Improvements #67

merged 1 commit into from
Jul 22, 2024

Conversation

vaughantnrc
Copy link
Collaborator

  • General restructuring of code for consistent style and conventions ("private" member protection)
  • Class names now generally indicate which "subcomponent" of Detector they belong to: Camera, Marker, Calibration
  • Detector configuration now has distinct sections for each of the "subcomponents"
  • Camera, Marker detection, and Calibration classes no longer deal with API data structures (that is instead handled in Detector)
  • Simpler communications between controller/GUI and Detector. Try to avoid roundtrips of data
  • Calibration images shall now be saved in lossless format (.png), fixes Change Calibration in GUI to use non-lossy images (PNG instead of JPEG) #18
  • Consolidate API classes into one api.py file, toward Too many small files #49
  • User can now specify which calibration to use (the "active" one) in the GUI.
  • Remove unused fields from various classes

I'm not sure whether to squash or not. Although I generally tested after each commit, I'm leaning toward squashing simply because this represents a general overhaul of Detector.

@keiranbarr
Copy link
Collaborator

Looks and works good for me.

@vaughantnrc
ENH: Updated Detector API and general cleanup
5ee751b 
Note the following commits were merged to create this commit:
BUG: Specify stream name for resolution (and image) in Picamera2Camera
BUG: Calibration images are now captured in lossless format
BUG: Handle Calibration Result updates better so there is at most one ACTIVE entry. Add missing result update functionality in Calibrator GUI.
ENH: Simplify startup communications (reduce number of exchanges) between controller and detector
ENH: Add Detector endpoint for getting camera resolution
ENH: Add Detector endpoint to get active calibration of current resolution
MNT: Reorganize configuration, clearer encapsulation of statuses, shorter function names in Detector
MNT: Remove unused field detector_serial_identifier from detector api
MNT: Allow simpler code calls to detector subcomponent functionality (camera, marker, calibrator)
BUG: Calibrator had no function add_status_message()
MNT: Remove detector_label from calibration keys/maps/filepaths (not foreseen to be useful)
MNT: Rename various Detector api classes, consolidate into a single file.
@vaughantnrc vaughantnrc force-pushed the dev-tv-detector-comms-simplification branch from 3f67573 to 5ee751b Compare July 22, 2024 15:38
@vaughantnrc vaughantnrc merged commit ac17989 into PerkLab:main Jul 22, 2024
@vaughantnrc
Copy link
Collaborator Author

Squashed and merged.

@vaughantnrc vaughantnrc deleted the dev-tv-detector-comms-simplification branch July 30, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Calibration in GUI to use non-lossy images (PNG instead of JPEG)
2 participants
@vaughantnrc @keiranbarr