Improve symbols lookup #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePedroo
added
bug
This commit improves how the symbols like solist are searched. This allows to phones that have linker64 with symbols with llvm suffix to still have maps hiding. closes #63
ThePedroo
force-pushed
the
improve/linker-symbols-lookup
branch
from
d25d6a4
to
f7b7615
Compare
3 tasks
|
Don't do linear lookup at the begining, try ElfLookup or GnuLookup could be faster. |
|
Sorry, my bad, hash algorithm won't work when the key is unknown. We indeed need linear searching. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit improves how the symbols like solist are searched, to search by its prefix instead of full name.
Why
This allows to phones that have linker64 with symbols with llvm suffix to still have maps hiding.
Checkmarks