-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callable workflow for Docker image build #3393
Open
infotroph
wants to merge
17
commits into
PecanProject:develop
Choose a base branch
from
infotroph:reuse-docker-build-workflow
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Callable workflow for Docker image build #3393
infotroph
wants to merge
17
commits into
PecanProject:develop
from
infotroph:reuse-docker-build-workflow
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infotroph
force-pushed
the
reuse-docker-build-workflow
branch
from
November 5, 2024 10:17
e5de1b4
to
920f231
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3374 by consolidating the Docker build process into a callable workflow, saving many lines of boilerplate.
Also switches build cache from Docker to GHCR, but does not yet address between-image dependencies that still assume they'll be pulling from Docker -- @robkooper hopefully this gives you an easier starting place for that?
Motivation and Context
Review Time Estimate
Types of changes
Checklist: