Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callable workflow for Docker image build #3393

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

infotroph
Copy link
Member

@infotroph infotroph commented Oct 23, 2024

Description

Fixes #3374 by consolidating the Docker build process into a callable workflow, saving many lines of boilerplate.

Also switches build cache from Docker to GHCR, but does not yet address between-image dependencies that still assume they'll be pulling from Docker -- @robkooper hopefully this gives you an easier starting place for that?

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@infotroph infotroph force-pushed the reuse-docker-build-workflow branch from e5de1b4 to 920f231 Compare November 5, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move repeated steps of docker.yml to a called workflow
2 participants