Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to code of conduct CONTRIBUTING.md #3376

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

dlebauer
Copy link
Member

@dlebauer dlebauer commented Sep 9, 2024

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mdietze
Copy link
Member

mdietze commented Sep 10, 2024

@robkooper could you check what's up with the required "baseplus" GHA that didn't run? I'm guessing this is a new action that you added with the Docker build refactor?

@robkooper
Copy link
Member

@robkooper could you check what's up with the required "baseplus" GHA that didn't run? I'm guessing this is a new action that you added with the Docker build refactor?

I was hoping that would capture all of the baseplus images, looks like i need to add them explicitly

@dlebauer dlebauer merged commit 75fc4de into develop Sep 12, 2024
27 of 28 checks passed
@dlebauer dlebauer deleted the dlebauer-patch-1 branch September 12, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants