-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relicense 16 more packages as BSD3 #3371
Conversation
@@ -1,6 +1,39 @@ | |||
## This is the master copy of the PEcAn License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kept both licenses in this file, just swapped BSD3 to the top now that we're past the halfway point
@@ -5,7 +5,8 @@ Version: 1.7.3.9000 | |||
Authors@R: c(person("Mike", "Dietze", role = c("aut", "cre"), | |||
email = "[email protected]"), | |||
person("Tristan", "Quaife", role = c("aut")), | |||
person("University of Illinois, NCSA", role = c("cph"))) | |||
person("University of Illinois, NCSA", role = c("cph")), | |||
person("Boston University", role = c("cph"))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only package so far where I have edited copyright holders in DESCRIPTION, because it's the only one where I deleted headers from R files that listed anyone other than UI/NCSA as a copyright holder.
As a separate project that doesn't need to tag everyone a zillion times, we could consider going back through to (1) check whether BU / UA / others need to be identified by name as copyright holders of other packages, and (2) update years as needed to indicate the full range of edit dates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend dropping the role rather than adding it elsewhere or expanding it to other universities or institutions. Blame says @robkooper added this here b0dd245 3 years ago, which is well after all of us except Rob left UIUC and I don't recall us collectively agreeing to give UIUC or NCSA copywrite permissions to the code. Seems like that should be granted to the PEcAn project, same as the licence
@@ -5,7 +5,8 @@ Version: 1.7.3.9000 | |||
Authors@R: c(person("Mike", "Dietze", role = c("aut", "cre"), | |||
email = "[email protected]"), | |||
person("Tristan", "Quaife", role = c("aut")), | |||
person("University of Illinois, NCSA", role = c("cph"))) | |||
person("University of Illinois, NCSA", role = c("cph")), | |||
person("Boston University", role = c("cph"))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend dropping the role rather than adding it elsewhere or expanding it to other universities or institutions. Blame says @robkooper added this here b0dd245 3 years ago, which is well after all of us except Rob left UIUC and I don't recall us collectively agreeing to give UIUC or NCSA copywrite permissions to the code. Seems like that should be granted to the PEcAn project, same as the licence
Do we want to assign the license to the PEcAn Project at some point? Since this is created across universities and companies now. |
Description
Updating the license files upon realizing we have agreement from all the contributors to these packages, who I will tag below to say: Thank you for all your work on these packages and for agreeing to the change! We have your agreement on file, so you don't have to take any further action for this PR.
This PR takes us well past the halfway point on relicensing all the PEcAn packages! Special thanks to those of y'all who've been tagged on every one of these PRs -- we're not done yet but getting close.
base/db: @Sweetdevil144 @ashiklom @helge22a @tonygardella @bcow @infotroph @dlebauer @DongchenZ @Aariq @istfer @jessicaguo @juliusvira @kzarada @KristinaRiemer @LiamBurke24 @Luke-Dramko @meetagrawal09 @mdietze @rahul799 @robkooper @allgandalf @moki1202 @serbinsh @nanu1605 @tezansahu @ankurdesai @araiho @para2x @mccabete @shubhamagarwal92
base/visualization: @ashiklom @helge22a @tonygardella @bcow @infotroph @DongchenZ @LiamBurke24 @mdietze @robkooper @allgandalf @moki1202 @nanu1605 @araiho @istfer @meetagrawal09 @rahul799
models/clm45: @ashiklom @bpbond @bcow @infotroph @DongchenZ @mdietze @robkooper @rykelly @nanu1605 @tonygardella @araiho @istfer @meetagrawal09
models/dalec: @ashiklom @tonygardella @bpbond @bcow @infotroph @dlebauer @DongchenZ @jam2767 @mdietze @robkooper @rykelly @serbinsh @nanu1605 @annethomas @araiho @istfer @meetagrawal09
models/jules: @ashiklom @bpbond @bcow @infotroph @DongchenZ @mdietze @rahul799 @robkooper @rykelly @nanu1605 @tonygardella @annethomas @istfer @meetagrawal09
models/linkages: @araiho @ashiklom @helge22a @tonygardella @bpbond @bcow @infotroph @dlebauer @DongchenZ @para2x @marissakivi @mdietze @robkooper @rykelly @moki1202 @serbinsh @nanu1605 @istfer
models/lpjguess: @ashiklom @bpbond @bcow @infotroph @DongchenZ @MagicForrest @mdietze @robkooper @rykelly @moki1202 @nanu1605 @tonygardella @araiho @istfer @meetagrawal09
models/preles: @ashiklom @tonygardella @bpbond @bcow @infotroph @dlebauer @DongchenZ @mdietze @rahul799 @robkooper @rykelly @moki1202 @nanu1605 @araiho @istfer @meetagrawal09
models/sipnet: @Sweetdevil144 @ashiklom @helge22a @ankurdesai @araiho @bailsofhay @bpbond @bcow @infotroph @dlebauer @DongchenZ @para2x @jam2767 @kzarada @Qianyuxuan @Luke-Dramko @meetagrawal09 @mdietze @robkooper @allgandalf @rykelly @serbinsh @nanu1605 @tonygardella @annethomas @istfer @mccabete
modules/allometry: @ashiklom @helge22a @andydawson @bpbond @bcow @infotroph @dlebauer @DongchenZ @jam2767 @mdietze @robkooper @allgandalf @moki1202 @serbinsh @tonygardella @araiho @crollinson @istfer @meetagrawal09 @rahul799
modules/assim.batch: @ashiklom @araiho @bpbond @bcow @infotroph @dlebauer @DongchenZ @istfer @mdietze @rahul799 @robkooper @rykelly @moki1202 @serbinsh @nanu1605 @mccabete @tonygardella @meetagrawal09
modules/meta.analysis: @Sweetdevil144 @ashiklom @bpbond @bcow @infotroph @dlebauer @DongchenZ @jessicaguo @kzarada @meetagrawal09 @mdietze @robkooper @rykelly @moki1202 @serbinsh @nanu1605 @tonygardella @annethomas @araiho @istfer
modules/photosynthesis: @ashiklom @bpbond @bcow @infotroph @dlebauer @DongchenZ @mdietze @robkooper @moki1202 @serbinsh @tonygardella @araiho @istfer @lovelilyinfall @meetagrawal09
modules/priors: @ashiklom @bpbond @bcow @infotroph @dlebauer @DongchenZ @meetagrawal09 @mdietze @robkooper @allgandalf @rykelly @moki1202 @serbinsh @nanu1605 @tonygardella @araiho @istfer @rahul799
shiny/BenchmarkReport: @bcow @infotroph
shiny/viewmet: @bcow @infotroph @rahul799 @robkooper @tonygardella
Motivation and Context
Review Time Estimate
Types of changes
Checklist: