WIP: use pak instead of confirm_deps for dependency installation #3367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EXPERIMENTAL, NEEDS TESTING: Use pak::local_install_deps() instead of our confirm_deps script.
Before merging, need to show that local_install_deps (1) behaves the same as confirm_deps with respect to installation behavior, and (2) does not query overeagerly for updates to dependencies. Recall that the original impetus for
confirm_deps
wasdevtools::install_deps
making too many queries to remote repos that we'd already checked earlier in the process. My read of the documentation suggests we should expect pak to be better about this, but I have not yet checked. Probably the easiest way to check would be by running the install process inside a container instrumented to monitor outgoing IP requests.Motivation and Context
Review Time Estimate
Types of changes
Checklist: