Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in depends action #3351

Merged
merged 2 commits into from
Aug 1, 2024
Merged

typo in depends action #3351

merged 2 commits into from
Aug 1, 2024

Conversation

infotroph
Copy link
Member

Description

Fixes a typo in an update that I meant to push as a separate PR but added to #3346 by mistake 🙈.

@robkooper FYI:

  • With this change, we're now building the Depends image every push for R{4.1, 4.2, 4.4}, and once a week for R{4.3, devel}. I plan to move 4.1 to weekly once we've finished bumping the supported version past it.
  • Note that the Rdevel image is built from a Rocker image that's currently out of date, but I propose to leave it configured to be ready when the Rocker folks get their build unstuck.
  • Once the depends images are all building, next step is to change the Actions workflows to test / build with the versions we want. I propose to wait until our current Ed2-git docker build issues are resolved before tackling this step.

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@infotroph infotroph merged commit 535b826 into PecanProject:develop Aug 1, 2024
12 of 13 checks passed
@infotroph infotroph deleted the fix-yml branch August 1, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants