Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relicense QAQC and PEcAn.STICS as BSD3 #3337

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

infotroph
Copy link
Member

@infotroph infotroph commented Jul 15, 2024

Updating the license file upon noting we have agreement from all contributors whose code is still present in that package.

@infotroph infotroph requested a review from meetagrawal09 July 15, 2024 05:39
@infotroph infotroph changed the title relicense QAQC as BSD3 relicense QAQC and PEcAn.STICS as BSD3 Jul 15, 2024
@dlebauer
Copy link
Member

I don't see the new licenses?

@infotroph
Copy link
Member Author

infotroph commented Jul 15, 2024

@dlebauer Good point. I've just added the BSD3 text to the LICENSE in the project root.

We're following CRAN's (weird IMO, but consistently documented) rule that for BSD3 the LICENSE file is a template that should contain only the year organization, and copyright holder, and that the built R package should not contain the entire text of the license.

I think providing one copy for the whole repo is enough, but if folks feel strongly about keeping license text in the source of every individual package we can add it as a file named something other than LICENSE (maybe LICENSE.txt?) and then add that to .Rbuildignore.

@robkooper
Copy link
Member

Should this not have the License file anymore?

License: BSD_3_clause + file LICENSE

@infotroph
Copy link
Member Author

infotroph commented Jul 15, 2024

@robkooper DESCRIPTION should still say "+ file LICENSE", and the file should still be there but with changed contents -- See my answer to David above.

@dlebauer
Copy link
Member

I agree one license file for the whole repo is enough. Mostly I think it is helpful when the license is clear when people find the GitHub repo.

@mdietze mdietze added this pull request to the merge queue Jul 16, 2024
Merged via the queue into PecanProject:develop with commit 2e87067 Jul 16, 2024
13 checks passed
@infotroph infotroph deleted the license-change-qaqc branch July 23, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants