Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Testing for do_conversions workflow #3306

Merged
merged 18 commits into from
Sep 23, 2024
Merged

Integration Testing for do_conversions workflow #3306

merged 18 commits into from
Sep 23, 2024

Conversation

meetagrawal09
Copy link
Collaborator

Description

This PR is aimed at adding integration tests for the do_conversions workflow.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@meetagrawal09 meetagrawal09 marked this pull request as draft June 16, 2024 06:38
Meet Agrawal and others added 2 commits June 16, 2024 12:13
@meetagrawal09 meetagrawal09 changed the title Intregration Testing for do_conversions workflow Integration Testing for do_conversions workflow Jun 16, 2024
@meetagrawal09 meetagrawal09 requested a review from infotroph June 16, 2024 06:59
infotroph
infotroph requested changes Jul 30, 2024
View reviewed changes
.github/workflows/download-data.yml Outdated Show resolved Hide resolved
.github/workflows/download-data.yml Outdated Show resolved Hide resolved
tests/docker.AmerifluxLBL.xml Outdated Show resolved Hide resolved
tests/docker.AmerifluxLBL.xml Outdated Show resolved Hide resolved
tests/docker.CRUNCEP.xml Outdated Show resolved Hide resolved
tests/docker.NOAA_GEFS.xml Outdated Show resolved Hide resolved
tests/docker.NOAA_GEFS.xml Outdated Show resolved Hide resolved
tests/docker.NOAA_GEFS.xml Outdated Show resolved Hide resolved
web/test.R Outdated Show resolved Hide resolved
web/test.R Outdated Show resolved Hide resolved
@meetagrawal09 meetagrawal09 marked this pull request as ready for review September 5, 2024 15:51
@infotroph infotroph enabled auto-merge September 5, 2024 16:09
@infotroph infotroph disabled auto-merge September 5, 2024 16:10
@infotroph infotroph enabled auto-merge September 5, 2024 16:11
@infotroph infotroph disabled auto-merge September 23, 2024 16:19
@infotroph infotroph merged commit fbac460 into PecanProject:develop Sep 23, 2024
16 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infotroph infotroph infotroph approved these changes

Assignees
No one assigned
Labels
GitHub Actions Tests Website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meetagrawal09 @infotroph