Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Notes in PEcAn.workflow #3261

Merged
merged 4 commits into from
Feb 18, 2024
Merged

Fixing Notes in PEcAn.workflow #3261

merged 4 commits into from
Feb 18, 2024

Conversation

meetagrawal09
Copy link
Collaborator

Description

This PR fixes notes and warning raised by R CMD check on PEcAn.workflow.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

infotroph
infotroph reviewed Feb 17, 2024
View reviewed changes
base/workflow/R/run.write.configs.R Outdated Show resolved Hide resolved
base/workflow/DESCRIPTION Show resolved Hide resolved
@infotroph infotroph enabled auto-merge February 18, 2024 18:50
@infotroph infotroph added this pull request to the merge queue Feb 18, 2024
Merged via the queue into PecanProject:develop with commit 5b9778b Feb 18, 2024
9 of 12 checks passed
@meetagrawal09 meetagrawal09 deleted the fix-checks branch February 18, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infotroph infotroph infotroph approved these changes

@mdietze mdietze Awaiting requested review from mdietze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meetagrawal09 @infotroph