-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rgdal and maptools from data.atmosphere #3228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istfer
commented
Nov 1, 2023
rh2m[s, hr] <- grib$band3[index] | ||
ugrd10m[s, hr] <- grib$band4[index] | ||
vgrd10m[s, hr] <- grib$band5[index] | ||
pressfc[s, hr] <- grib_data_df$`SFC=Ground or water surface; Pressure [Pa]`[index] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if you want to access these by index, for now I used the fullnames
mdietze
approved these changes
Nov 1, 2023
istfer
changed the title
Remove rgdal from data.atmosphere
Remove rgdal and maptools from data.atmosphere
Nov 1, 2023
Not sure how to resolve CI errors with this one. I ran generate dependencies and
|
Merged
via the queue into
PecanProject:develop
with commit Nov 6, 2023
91531ae
10 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per issue #2914 made changes to data.atmosphere. Modified places where rgdal and maptools were used, shouldn't break anything.
Motivation and Context
See #2914. We have to keep downgrading our R versions because of these packages.
Review Time Estimate
Types of changes
Checklist: