Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rgdal and maptools from data.atmosphere #3228

Merged
merged 12 commits into from
Nov 6, 2023

Conversation

istfer
Copy link
Contributor

@istfer istfer commented Nov 1, 2023

Description

Per issue #2914 made changes to data.atmosphere. Modified places where rgdal and maptools were used, shouldn't break anything.

Motivation and Context

See #2914. We have to keep downgrading our R versions because of these packages.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@istfer istfer changed the title Remove rgdal data atmosphere Remove rgdal from data.atmosphere Nov 1, 2023
rh2m[s, hr] <- grib$band3[index]
ugrd10m[s, hr] <- grib$band4[index]
vgrd10m[s, hr] <- grib$band5[index]
pressfc[s, hr] <- grib_data_df$`SFC=Ground or water surface; Pressure [Pa]`[index]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if you want to access these by index, for now I used the fullnames

@istfer istfer changed the title Remove rgdal from data.atmosphere Remove rgdal and maptools from data.atmosphere Nov 1, 2023
@istfer
Copy link
Contributor Author

istfer commented Nov 3, 2023

Not sure how to resolve CI errors with this one. I ran generate dependencies and suntools is in docker/depends/pecan.depends.R list

document modules/data.atmosphere
  ℹ Updating PEcAn.data.atmosphere documentation
  ℹ Loading PEcAn.data.atmosphere
  Error in load_imports(path) : The package "suntools" is required.
  Calls: <Anonymous> ... load_imports -> deps_check_installed -> check_installed
  Execution halted
  make: *** [Makefile:174: .doc/modules/data.atmosphere] Error 1
  Error: Process completed with exit code 2.

@mdietze mdietze enabled auto-merge November 6, 2023 19:56
@mdietze mdietze added this pull request to the merge queue Nov 6, 2023
Merged via the queue into PecanProject:develop with commit 91531ae Nov 6, 2023
10 of 12 checks passed
@istfer istfer deleted the rgdal_data_atmosphere branch November 29, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants