Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix check warnings/notes in benchmark package #3217

Merged
merged 21 commits into from
Mar 4, 2024
Merged

fix check warnings/notes in benchmark package #3217

merged 21 commits into from
Mar 4, 2024

Conversation

moki1202
Copy link
Collaborator

No description provided.

@moki1202 moki1202 marked this pull request as ready for review September 18, 2023 02:18
mdietze
mdietze requested changes Sep 20, 2023
View reviewed changes
Copy link
Member

@mdietze mdietze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The only thing that's missing here, and in your other PRs, is an update to the Rcheck_reference.log to remove the error messages that you have fixed so that these same errors can't be reintroduced.

@moki1202 moki1202 force-pushed the fix_warnings_benchmark branch from 3e33cff to c3e60a8 Compare November 3, 2023 07:16
@moki1202 moki1202 force-pushed the fix_warnings_benchmark branch from c3e60a8 to 47dd6f8 Compare November 3, 2023 07:18
infotroph
infotroph reviewed Jan 11, 2024
View reviewed changes
modules/benchmark/R/get_species_list_standard.R Outdated Show resolved Hide resolved
modules/benchmark/R/align_data.R Outdated Show resolved Hide resolved
modules/benchmark/R/metric_residual_plot.R Outdated Show resolved Hide resolved
modules/benchmark/R/metric_timeseries_plot.R Outdated Show resolved Hide resolved
infotroph
infotroph requested changes Feb 13, 2024
View reviewed changes
modules/benchmark/R/metric_lmDiag_plot.R Outdated Show resolved Hide resolved
modules/benchmark/R/metric_lmDiag_plot.R Outdated Show resolved Hide resolved
modules/benchmark/R/metric_lmDiag_plot.R Outdated Show resolved Hide resolved
modules/benchmark/R/metric_lmDiag_plot.R Outdated Show resolved Hide resolved
modules/benchmark/R/metric_lmDiag_plot.R Outdated Show resolved Hide resolved
modules/benchmark/R/metric_lmDiag_plot.R Outdated Show resolved Hide resolved
modules/benchmark/R/metric_lmDiag_plot.R Outdated Show resolved Hide resolved
modules/benchmark/R/metric_scatter_plot.R Outdated Show resolved Hide resolved
modules/benchmark/R/metric_timeseries_plot.R Outdated Show resolved Hide resolved
@infotroph infotroph self-requested a review March 3, 2024 09:04
@infotroph infotroph requested a review from mdietze March 3, 2024 09:05
@mdietze mdietze added this pull request to the merge queue Mar 4, 2024
Merged via the queue into PecanProject:develop with commit 62f8f51 Mar 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdietze mdietze mdietze approved these changes

@infotroph infotroph infotroph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moki1202 @infotroph @mdietze