-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Optimize CI Pipeline Code #3195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
I think the "expected" tests are ones that are removed in this PR -- I believe a repo admin will need to go into GitHub's branch protection settings and remove those from the list of required tests. |
yes, this was done with my last PR for the CI workflow as well 😁, feeling a little guilty over here 😅 |
With this PR, we also need to disable the Required checks for |
7894a8b
Description
Referencing to the issue #3194, this PR aims to reduce the code duplication by setting the check command variables as Matrix variables.
Motivation and Context
After the first CI optimization PR, there was a little discussion by @infotroph that we cloud use matrix variables to reduce the code duplication which occurs in the current code.
Review Time Estimate
Types of changes
Checklist:
This PR resolves #3194