Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECMWF Open Data download and conversion functions #2975
base: develop
Are you sure you want to change the base?
ECMWF Open Data download and conversion functions #2975
Changes from 1 commit
4c7c9d3
4fcf7e9
9d1d773
ae5547b
b7a2b92
78f5c9a
0b9de44
722b728
312ecd4
ebbcffd
4646cbc
fff01ec
7ace24b
624df23
08a95a2
048dbdf
4a40533
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this condition is not met there will be no
parameter_types
, then line 61 will most likely throw a'parameter_types' not found
error, should there be anelse
to thisif
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
else
to show what can be given as an input, hereall
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is remains to be the case, please add an
else
to make sureparameter_types
are assigned something in casetolower(parameters) != "all"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
tolower(parameters) != "all"
should theparameter_types
still be"all"
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no
step
variable, was this supposed to bestep_15day
?