Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LICENSE to BSD 3-Clause #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cryolune
Copy link
Member

Description

This PR updates the License of PecAn Status Board to BSD 3-Clause

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the LICENSE
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cryolune
Copy link
Member Author

@infotroph Could you please review the changes in the license?

@infotroph
Copy link
Member

Thanks for doing this! While we're at it, let's bring the license format in line with the CRAN requirement for R packages, (which is kinda weird compared to packages in most other languages, TBH). Following the format recommended by usethis, can you please:

  • In DESCRIPTION, change License: NCSA to License: BSD_3_clause + file LICENSE.
  • Move the actual license text from LICENSE to LICENSE.md
  • Confirm that .Rbuildignore contains a line matching LICENSE.md so that it's provided to everyone who downloads the source code but is not included in the installed package.
    • It is a CRAN requirement to not include the license text in the built package; I disagree with this but we follow it anyway.
    • My understanding of their reasoning is that R provides built-in ways to read the text of all the standard licenses, so providing another copy of it in every package is super-redundant even though each individual copy is small.
  • Edit the LICENSE file to contain only the following text (think of this as a template to fill in the blanks in the BSD license)
    YEAR: 2024
    COPYRIGHT HOLDER: PEcAn Project
    ORGANIZATION: PEcAn Project, authors affiliations
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants