Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Icon Usage to Standard Font Awesome Icons #16

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

Sweetdevil144
Copy link
Contributor

@Sweetdevil144 Sweetdevil144 commented Mar 18, 2024

Decription

This Pull Request introduces changes to the icon usage within the Shiny dashboard application. The primary change is the update of custom or non-standard icon references to standard Font Awesome icons. Specifically, instances of the icon "square-C" have been replaced with the standard Font Awesome icon "square". This update ensures compatibility with the Font Awesome library and addresses issues related to non-recognizable icons.

By the end, this PR intends to fix #13.

Changes

  • Replaced non-standard icon references (such as "square-C") with the standard Font Awesome icon "square".
  • Applied this change in all instances where the non-standard icons were used, particularly within shinydashboard::menuSubItem.

Impact

  • These changes should not affect the overall functionality of the application.
  • Users should see the standard square icon from Font Awesome instead of the previously intended custom icon. Error logs should disappear too by the end of PR.

Note

  • This PR is a part of ongoing debugging efforts. Although this update addresses specific icon-related issues, further investigation and fixes may be required to resolve other error logs as mentioned previously.
  • Feedback and additional insights into the error logs are welcome to aid in comprehensive troubleshooting.

@Sweetdevil144
Copy link
Contributor Author

@theakhiljha Can you help with debugging this if you find time to review these logs?

@mdietze mdietze merged commit 048f416 into PecanProject:main Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Loading Test Results
2 participants