Skip to content
This repository has been archived by the owner on Nov 9, 2021. It is now read-only.

Issue #31 travis-ci integration and Issue #35 include markdown extra #37

Closed
wants to merge 2 commits into from
Closed

Conversation

treffynnon
Copy link
Contributor

Issue #31

I have attempted to get travis-ci builds to work. The tests are erroring out for me on both my development machine and up on travis-ci so I think perhaps there is a regression in the tests.

So here is the output of the travis-ci build: http://travis-ci.org/#!/treffynnon/phrozn/jobs/627500

travis-ci is now up and running for phrozn, but some of the assertions are not passing. So this should close issue #31, but may need additional work.

Issue #35

Replaced the markdown parser with Markdown Extra.

@sasezaki
Copy link
Contributor

sasezaki commented Feb 5, 2012

Great!
"InvalidArgumentException: You must not expect the generic exception class."
This failure seems invoked by PHPUnit 3.6's break.
https://twitter.com/#!/s_bergmann/status/163638051967471616
@farazdagi What's PHPUnit version for Phrozn develop ?

@farazdagi
Copy link
Collaborator

@treffynnon Thanks! Can you please resubmit your request against dev branch? We are using master branch to push versions into production, all development occurs in dev branch.

@sasezaki I will need to review 3.7 changelog, to see what version will be used as default for Phrozn development. Then plan to update the documentation.

@farazdagi farazdagi closed this Feb 5, 2012
@treffynnon
Copy link
Contributor Author

@sasezaki it looks like @farazdagi is targeting PHPUnit 3.5 looking at the test output at http://test.phrozn.info - the PHPUnit version is in the page footer.

I hadn't noticed till now. So it looks like the tests might need some updating or the travis-ci configuration could be amended to downgrade the PHPUnit version before the build, but this is complicated. See https://github.com/lenada/travis-phpunit34/blob/master/.travis.yml from travis-ci/travis-ci#406

@farazdagi
Copy link
Collaborator

@treffynnon I will update all tests and make sure they are passing, so that configuration changes you made are enough :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants