Do not disable delayed delivery since currently the FIFO queue is anyway always required by the transport #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…way always required by the transport
danielmarbach
requested review from
mauroservienti,
tmasternak and
poornimanayar
kentdr
approved these changes
Feb 23, 2024
mauroservienti
approved these changes
Feb 29, 2024
tmasternak
approved these changes
Mar 1, 2024
|
FYI The failing test has been fixed in #292 so either wait for that to be merged or merge this one into that branch The docs seems to be a bit of in regards to serializer and need for the error queue to be set so I will fix that https://docs.particular.net/nservicebus/hosting/aws-lambda-simple-queue-service/ |
|
@andreasohlund would you be able to cherry-pick this change over there? |
|
I've cherry-picked the commit, I'll take care of updating the docs. https://docs.particular.net/nservicebus/hosting/aws-lambda-simple-queue-service/#configuration-delayed-retries |
|
That's all I'm aware of yes |
|
Merged as part of #292 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment in the code was misleading since the delayed message pump is always initialized which checks for the existence of the fifo queue.