Add shared_fs and staging_required test markers
#3669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benclifford
requested changes
Oct 31, 2024
|
@benclifford I believe all of the bits that you noted are now fixed. |
benclifford
changed the title
shared_fs and staging_required markersshared_fs and staging_required test markers
benclifford
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
staging_requiredmarker and a marker to several tests that assume a shared filesystem to work. Similarly, a few tests that use staging are now marked with thestaging_requiredmarker.This PR splits out changes from #3607.
Changed Behaviour
These markers should not affect any test-behavior since none of the test entries in the Makefile make use of this.
These change will kick-in once they are used by
GlobusComputeExecutorand potentiallyKubernetesProviderfor tests.
Type of change
Choose which options apply, and delete the ones which do not apply.