Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close processes in Work Queue and Task Vine shutdown #3576

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Close processes in Work Queue and Task Vine shutdown #3576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions parsl/executors/taskvine/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,11 +589,13 @@ def shutdown(self, *args, **kwargs):
# Join all processes before exiting
logger.debug("Joining on submit process")
self._submit_process.join()
self._submit_process.close()
logger.debug("Joining on collector thread")
self._collector_thread.join()
if self.worker_launch_method == 'factory':
logger.debug("Joining on factory process")
self._factory_process.join()
self._factory_process.close()

# Shutdown multiprocessing queues
self._ready_task_queue.close()
Expand Down
2 changes: 2 additions & 0 deletions parsl/executors/workqueue/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,8 @@ def shutdown(self, *args, **kwargs):

logger.debug("Joining on submit process")
self.submit_process.join()
self.submit_process.close()

logger.debug("Joining on collector thread")
self.collector_thread.join()

Expand Down
Loading