Skip to content

Commit

Permalink
Join on stopped thread at end of LocalProvider+ssh test (#3505)
Browse files Browse the repository at this point in the history
This stops that thread being left still running over the end of the
test - which is needed in work in PR #3397 to ensure that no threads
are left running at the end of a test.

If that shutdown hangs, this test will now hang rather than leave the
thread behind.

Along with PR #3504, this eliminates any threads left behind after
parsl/tests/test_providers/test_local_provider.py
  • Loading branch information
benclifford authored Jul 3, 2024
1 parent cfb0a20 commit 2cc3ec5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions parsl/tests/test_providers/test_local_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ def test_ssh_channel():

def _stop_sshd(sshd_thread):
sshd_thread.stop()
sshd_thread.join()


class SSHDThread(threading.Thread):
Expand Down

0 comments on commit 2cc3ec5

Please sign in to comment.