-
Notifications
You must be signed in to change notification settings - Fork 232
Feature SASL SCRAM support #972
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
==========================================
- Coverage 83.53% 81.98% -1.55%
==========================================
Files 36 37 +1
Lines 3807 4468 +661
Branches 562 682 +120
==========================================
+ Hits 3180 3663 +483
- Misses 483 565 +82
- Partials 144 240 +96
Continue to review full report at Codecov.
|
Ditched kafka 0.8 because there were too many issues getting it to run. It neither supports SSL nor SASL, the configs differ significantly and there seems to be an issue with its zk client. I thought it's more useful to test kafka 2 instead. Switched to librdkafka 0.11.5 because 0.9.5 doesn't support the SCRAM mechanisms. In the end I didn't choose a 1.x version since it introduces another configuration issue that I didn't want to solve. I went far out of scope fixing several issues with CI and the tests which took me a lot longer than actually implementing the feature. |
Could someone please just take a look at this PR? I think @swenzel has done some great work here which really pushes pykafka forward at should be a high priority to work on. |
Hi, I would also like to see this merged! :D |
Any news? |
Look forward to this feature. |
This pull request adds support for modular SASL authentication mechanisms with two mechanisms (PLAIN, SCRAM) already implemented.
closes #651