Prepare ParselyTracker for Kotlin migration
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasons: to reduce responsibilities of `ParselyTracker` and introduce unit tests coverage for "no internet connection" case
Instead of returning `-1` in case of missing interval
BREAKING CHANGE: this method was part of the public contract but I can't find a justified value of it
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 68.24% 69.25% +1.00%
==========================================
Files 16 18 +2
Lines 359 361 +2
Branches 52 52
==========================================
+ Hits 245 250 +5
+ Misses 97 95 -2
+ Partials 17 16 -1 ☔ View full report in Codecov by Sentry. |
wzieba
commented
Dec 13, 2023
|
|
||
| import java.util.Formatter | ||
|
|
||
| object Logging { |
There was a problem hiding this comment.
At this moment I can't make this object internal because it won't be visible for Java classes. When the migration from Java to Kotlin is completed, I'll make sure to make it internal.
In case of an empty `url` parameter, the SDK should not crash the application. The logging SDK is likely not as critical to the consumer business flow to the degree, that providing an incorrect argument would kill the whole process.
wzieba
deleted the
issue/prepare_for_parsely_tracker_kotlin_migration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a set of changes that aim to reduce the size of
ParselyTrackerto reduce the responsibilities of this class and make the transition from Java to Kotlin more readable and easier to review.Testing
I see no need for manual tests of this PR. Unit and functional tests suite should be just fine.