build: get version from the latest tag #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hardcoding version in repository files.
By default, the `actions/checkout` action fetches only the latest commit (`--depth=1`). We needed to fetch complete history of commits and tags to correctly determine version of the library.
wzieba
force-pushed
the
issue/50_use_git_tag_when_publishing_library
branch
from
6df6a4e to
d62d1b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding version in repository files.
Closes: #50
Description
This PR is a small improvement to the release process. Instead of updating a hard-coded version, now the version will be determined by the latest Git tag. It saves a little of overhead and number of actions needed to release a new SDK.
How to test
publication.gradlesigningextension (no need to test artifacts signing)git tag parsely_testing./gradlew publishToMavenLocal~/.m2/repository/com/parsely/parsely/parsely_testingparsely_testing.pom<version>parsely_testing</version>taggit tag -d parsely_testing)3.0.8version (latest tag)Documentation update
If this PR will be merged, I'll update our internal documentation to reflect this change.