refactor: change result type of ParselyAPIConnection to Void

There's no need to return `HttpURLConnection`. This change simplifies implementation.
Parsely · Oct 20, 2023 · c8795c0 · c8795c0
1 parent 8756b27
commit c8795c0
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/parsely/src/main/java/com/parsely/parselyandroid/ParselyAPIConnection.java b/parsely/src/main/java/com/parsely/parselyandroid/ParselyAPIConnection.java
@@ -24,7 +24,7 @@
 import java.net.URL;
 import java.net.HttpURLConnection;
 
-class ParselyAPIConnection extends AsyncTask<String, Exception, HttpURLConnection> {
+class ParselyAPIConnection extends AsyncTask<String, Exception, Void> {
 
     @NonNull
     private final ParselyTracker tracker;
@@ -35,7 +35,7 @@ class ParselyAPIConnection extends AsyncTask<String, Exception, HttpURLConnectio
     }
 
     @Override
-    protected HttpURLConnection doInBackground(String... data) {
+    protected Void doInBackground(String... data) {
         HttpURLConnection connection = null;
         try {
             if (data.length == 1) {  // non-batched (since no post data is included)
@@ -54,12 +54,12 @@ protected HttpURLConnection doInBackground(String... data) {
 
         } catch (Exception ex) {
             this.exception = ex;
-            return null;
         }
-        return connection;
+        return null;
     }
 
-    protected void onPostExecute(HttpURLConnection conn) {
+    @Override
+    protected void onPostExecute(Void result) {
         if (this.exception != null) {
             ParselyTracker.PLog("Pixel request exception");
             ParselyTracker.PLog(this.exception.toString());