refactor: introduce RestClient interface

Makes creating fake objects less problematic by removing a need to call real object constructor.
Parsely · Nov 17, 2023 · a13485c · a13485c
1 parent be74b28
commit a13485c
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 16 deletions.
diff --git a/parsely/src/main/java/com/parsely/parselyandroid/ParselyAPIConnection.kt b/parsely/src/main/java/com/parsely/parselyandroid/ParselyAPIConnection.kt
@@ -17,12 +17,13 @@ package com.parsely.parselyandroid
 
 import java.net.HttpURLConnection
 import java.net.URL
-import kotlinx.coroutines.CoroutineDispatcher
-import kotlinx.coroutines.Dispatchers
-import kotlinx.coroutines.withContext
 
-internal open class ParselyAPIConnection(private val url: String) {
-    open suspend fun send(payload: String): Result<Unit> {
+internal interface RestClient {
+    suspend fun send(payload: String): Result<Unit>
+}
+
+internal class ParselyAPIConnection(private val url: String) : RestClient {
+    override suspend fun send(payload: String): Result<Unit> {
         var connection: HttpURLConnection? = null
         try {
             connection = URL(url).openConnection() as HttpURLConnection

diff --git a/parsely/src/main/java/com/parsely/parselyandroid/SendEvents.kt b/parsely/src/main/java/com/parsely/parselyandroid/SendEvents.kt
@@ -9,7 +9,7 @@ import kotlinx.coroutines.sync.withLock
 internal class SendEvents(
     private val flushManager: FlushManager,
     private val repository: QueueRepository,
-    private val parselyAPIConnection: ParselyAPIConnection,
+    private val restClient: RestClient,
     private val scope: CoroutineScope
 ) {
 
@@ -35,7 +35,7 @@ internal class SendEvents(
                     repository.remove(eventsToSend)
                 } else {
                     ParselyTracker.PLog("Requested %s", ParselyTracker.ROOT_URL)
-                    parselyAPIConnection.send(jsonPayload)
+                    restClient.send(jsonPayload)
                         .fold(
                             onSuccess = {
                                 ParselyTracker.PLog("Pixel request success")

diff --git a/parsely/src/test/java/com/parsely/parselyandroid/SendEventsTest.kt b/parsely/src/test/java/com/parsely/parselyandroid/SendEventsTest.kt
@@ -21,7 +21,7 @@ class SendEventsTest {
             sut = SendEvents(
                 FakeFlushManager(),
                 FakeRepository(),
-                FakeParselyAPIConnection(),
+                FakeRestClient(),
                 this
             )
 
@@ -40,7 +40,7 @@ class SendEventsTest {
             val repository = FakeRepository().apply {
                 insertEvents(listOf(mapOf("test" to 123)))
             }
-            val parselyAPIConnection = FakeParselyAPIConnection().apply {
+            val parselyAPIConnection = FakeRestClient().apply {
                 nextResult = Result.success(Unit)
             }
             sut = SendEvents(
@@ -68,7 +68,7 @@ class SendEventsTest {
             sut = SendEvents(
                 FakeFlushManager(),
                 repository,
-                FakeParselyAPIConnection(),
+                FakeRestClient(),
                 this
             )
 
@@ -87,7 +87,7 @@ class SendEventsTest {
             val repository = FakeRepository().apply {
                 insertEvents(listOf(mapOf("test" to 123)))
             }
-            val parselyAPIConnection = FakeParselyAPIConnection().apply {
+            val parselyAPIConnection = FakeRestClient().apply {
                 nextResult = Result.failure(Exception())
             }
             sut = SendEvents(
@@ -113,7 +113,7 @@ class SendEventsTest {
             val repository = FakeRepository().apply {
                 insertEvents(listOf(mapOf("test" to 123)))
             }
-            val parselyAPIConnection = FakeParselyAPIConnection().apply {
+            val parselyAPIConnection = FakeRestClient().apply {
                 nextResult = Result.success(Unit)
             }
             sut = SendEvents(
@@ -139,7 +139,7 @@ class SendEventsTest {
             val repository = FakeRepository().apply {
                 insertEvents(listOf(mapOf("test" to 123)))
             }
-            val parselyAPIConnection = FakeParselyAPIConnection().apply {
+            val parselyAPIConnection = FakeRestClient().apply {
                 nextResult = Result.failure(Exception())
             }
             sut = SendEvents(
@@ -167,7 +167,7 @@ class SendEventsTest {
                     return ArrayList(listOf(mapOf("test" to 123)))
                 }
             }
-            val parselyAPIConnection = FakeParselyAPIConnection().apply {
+            val parselyAPIConnection = FakeRestClient().apply {
                 nextResult = Result.success(Unit)
             }
             sut = SendEvents(
@@ -192,7 +192,7 @@ class SendEventsTest {
         sut = SendEvents(
             flushManager,
             FakeRepository(),
-            FakeParselyAPIConnection(),
+            FakeRestClient(),
             this
         )
 
@@ -236,7 +236,7 @@ class SendEventsTest {
         }
     }
 
-    private class FakeParselyAPIConnection : ParselyAPIConnection("") {
+    private class FakeRestClient : RestClient {
 
         var nextResult: Result<Unit>? = null