Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/use configfree tracker #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joshuarrrr
Copy link

Copy link

@rachelannelise rachelannelise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! I'm assuming the removing of all the items is from the legacy tracker.

My only question is - it looks like old line 41 was ensuring this was inserted in the HEAD - is there somewhere else that should be checked since that line was removed?

@joshuarrrr
Copy link
Author

My only question is - it looks like old line 41 was ensuring this was inserted in the HEAD - is there somewhere else that should be checked since that line was removed?

That line was only for the <meta> tag element that was previously needed for setting the Parse.ly apikey - as we're no longer adding that element, there's no need to put it in the head. As for the tracker itself, we explicitly don't recommend placing it in the document head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants