Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor core for v4 #240

Merged
merged 39 commits into from
Jan 8, 2023
Merged

♻️ Refactor core for v4 #240

merged 39 commits into from
Jan 8, 2023

Conversation

karakoo
Copy link
Member

@karakoo karakoo commented Nov 1, 2022

该 PR 相关 Issue / Involved issue

#149

描述 / Description

重写core以适配 v4 的 feature

更改检查表 / Change Checklist

  • 有插件命令更新
    • 已更新 bot 帮助文件
  • 有流程交互
    • 指引明确
    • 可以退出
  • 会触发频率限制
    • 有对应的限制措施
  • 需要用户输入数据
    • 验证用户数据
    • 如果是文件,检查了文件大小
    • 对保存的数据再次进行了验证
  • 添加了新的依赖包
  • 测试
    • 本地通过了测试
    • CI 通过了测试

说明 / Note

暂无

@karakoo karakoo added the refactor ♻ Refactor label Nov 1, 2022
@karakoo karakoo self-assigned this Nov 1, 2022
@karakoo karakoo linked an issue Nov 1, 2022 that may be closed by this pull request
10 tasks
@luoshuijs luoshuijs force-pushed the main branch 3 times, most recently from f32bf99 to 7219235 Compare November 1, 2022 14:00
Signed-off-by: Karako <[email protected]>
Signed-off-by: Karako <[email protected]>
@luoshuijs luoshuijs force-pushed the main branch 5 times, most recently from d24b48f to 762c9bc Compare November 17, 2022 08:35
Signed-off-by: Karako <[email protected]>
Signed-off-by: Karako <[email protected]>
Signed-off-by: Karako <[email protected]>
# Conflicts:
#	plugins/genshin/avatar_list.py
Signed-off-by: Karako <[email protected]>
@luoshuijs

This comment was marked as resolved.

Signed-off-by: Karako <[email protected]>
# Conflicts:
#	core/bot.py
#	plugins/system/new_member.py
@luoshuijs luoshuijs changed the base branch from main to v4/main January 8, 2023 08:16
@luoshuijs luoshuijs marked this pull request as ready for review January 8, 2023 08:17
Copy link
Contributor

@luoshuijs luoshuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没什么问题了,剩下CI问题交给后续我解决了。

@luoshuijs luoshuijs removed a link to an issue Jan 8, 2023
10 tasks
@luoshuijs luoshuijs merged commit 433c0a4 into v4/main Jan 8, 2023
@luoshuijs luoshuijs added approved ✅ Pull request approved and removed Do not merge (yet) ⛔️ labels Jan 8, 2023
@luoshuijs luoshuijs mentioned this pull request Jan 8, 2023
15 tasks
@karakoo karakoo deleted the v4/core branch January 29, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ✅ Pull request approved breaking💥 Breaking changes refactor ♻ Refactor v4 🌟 version 4
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants