Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

映射文档 No. 38 #5833

Merged
merged 4 commits into from
Apr 28, 2023
Merged

映射文档 No. 38 #5833

merged 4 commits into from
Apr 28, 2023

Conversation

eternalmeteor
Copy link
Contributor

完成对映射文件No.38的工作。

@paddle-bot
Copy link

paddle-bot bot commented Apr 24, 2023

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-5833.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

@eternalmeteor
Copy link
Contributor Author

eternalmeteor commented Apr 26, 2023

你好,我对分组ID 38 #5691 中的10个api进行了映射,其中5个已经存在,我只是对其md文件的格式和部分参数进行了相应的修改。

@eternalmeteor
Copy link
Contributor Author

@Tomoko-hjf 麻烦看一下~谢谢

Copy link
Collaborator

@huajiao-hjyp huajiao-hjyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有一个共性问题,所有的示例代码需要本地测试一下能不能跑通,输入可以用torch.tensor()paddle.to_tensor()转换一下,不能给用户一个错误的示例,辛苦修改一下~

#### out:指定输出
```python
# Pytorch 写法
torch.digamma([[1, 1.5], [0, -2.2]], out=y)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里示例的写法是不对的,输入必须是tensor,不能是list,可以直接 torch.digamma(x, out=y)

可以用x表示,或者用torch.tensor([[1, 1.5], [0, -2.2]])转换一下,但不能给用户一个错误的示例,下面的示例也需要修改一下~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

您好,我这边已经将所有的示例进行了修改和测试,麻烦您再检查一下,谢谢~

Copy link
Collaborator

@huajiao-hjyp huajiao-hjyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit 4e0381e into PaddlePaddle:develop Apr 28, 2023
@luotao1
Copy link
Collaborator

luotao1 commented Apr 28, 2023

hi, @eternalmeteor

  • 非常感谢你对飞桨框架的贡献,我们正在运营一个PFCC组织,会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献,详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣,请发送邮件至 [email protected],我们会邀请你加入~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants